JsonPatch value should not be an object

[tete17]

Information

According to this

skaffold/docs/content/en/schemas/v2beta1.json

Line 1342 in 0a3254e

"type": "object",

a json patch value must always be an object.

This conflicts with the "official" definition of a json patch according to http://json.schemastore.org/json-patch.

Sometime when adding into a map it just needs to be a string or any other json object.

...
deploy:
  helm:
    releases:
      - name: foo
        chartPath: k8s/helm/bar
        values:
          foo: "bar"

profiles:
  - name: dev
    patches:
      - op: add
        path: /deploy/helm/releases/0/values/environmentName
        value: "dev"

My Clion editor complains because of this

I would change it myself but I am not familiar with the policy on how far back we can change the json schemas or if we need to generate a new version for this change

[nkubala]

@tete17 thanks for filing. I'm not super familiar with this either, but are strings not treated as objects in JSON schema? what should it be instead?

[tete17]

Hi @nkubala

I think a json object would correspond more or less to a map[string]JsonValue or in my beloved c++ std::map<std::string,JsonValue> where JsonValue could be a string, object, array or numeric value.

Reference: https://www.json.org/json-en.html

Regarding on how to specify this in the json schema, I believe it is sufficient to remove the type key of the map i mentioned before.

Alternative we may want to depend on the upstream definition of a JsonPatch I mentioned before. I believe json schemas have a vay to reference external definitions but I don't remember the specifics.

How do we proceed with the changes can the previous definitions be changed or do we create a new version (like apiVersion: v2beta#Number+1)?