Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json schema] When we don’t know a field’s type, let’s leave it empty #3964

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[json schema] When we don’t know a field’s type, let’s leave it empty #3964

merged 1 commit into from
Apr 21, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 16, 2020

Fixes #3932

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #3964 into master will not change coverage.
The diff coverage is n/a.

@dgageot
Copy link
Contributor Author

dgageot commented Apr 21, 2020

Self merging this small fix

@dgageot dgageot merged commit f16bafa into GoogleContainerTools:master Apr 21, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonPatch value should not be an object
3 participants
@dgageot @tstromberg @googlebot