Remove plugin code from config, upgrade to v1beta10 #2016
Conversation
remove all schemas associated with builder plugins
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
+ Coverage 55.49% 55.84% +0.34%
==========================================
Files 173 175 +2
Lines 7512 7498 -14
==========================================
+ Hits 4169 4187 +18
+ Misses 2952 2913 -39
- Partials 391 398 +7
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // convert Build (should be same) | ||
| var newBuild next.BuildConfig |
There was a problem hiding this comment.
In the Notes, you mention "Removed all schemas associated with the builder plugin".
Right now, looks like you are ignoring the plugin (looking at the upgrade_test.go) which will work for "docker" plugin since docker Artifact is the default.
If the plugin type was something else, like "bazel", we need to convert it to old style where artifact type will be now "bazel"?
Basically, https://github.com/GoogleContainerTools/skaffold/blob/v0.27.0/pkg/skaffold/build/plugin/plugin.go#L51
flow where bazel can appear https://github.com/GoogleContainerTools/skaffold/blob/v0.27.0/pkg/skaffold/build/plugin/core.go#L36
There was a problem hiding this comment.
Great point, added a fix for that in upgrade and a test in upgrade_test
I accidentally upgraded to v1beta10 in GoogleContainerTools#2016 when v1beta9 had yet to be released. To fix this, I've removed v1beta10 and merged the original v1beta9->v1beta10 upgrade into the current v1beta8->v1beta9 upgrade.
Continues work on #1988