Remove upgrade to v1beta10 #2030
Conversation
I accidentally upgraded to v1beta10 in GoogleContainerTools#2016 when v1beta9 had yet to be released. To fix this, I've removed v1beta10 and merged the original v1beta9->v1beta10 upgrade into the current v1beta8->v1beta9 upgrade.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
| name: bazel | ||
| properties: | ||
| target: //mytarget | ||
| executionEnvironment: |
There was a problem hiding this comment.
This is gone in the v1beta8.upgrade_test, whereas it was present in v1beta9.upgrade_test. Is this intentional?
There was a problem hiding this comment.
Good catch - I think it should be in v1beta8.upgrade_test as we had plugins/executionEnv in v1beta8 and removing them in v1beta9
@priyawadhwa ?
There was a problem hiding this comment.
There should be tests for this now, thanks!
Codecov Report
@@ Coverage Diff @@
## master #2030 +/- ##
=========================================
Coverage ? 55.96%
=========================================
Files ? 173
Lines ? 7556
Branches ? 0
=========================================
Hits ? 4229
Misses ? 2924
Partials ? 403
Continue to review full report at Codecov.
|
I accidentally upgraded to v1beta10 in #2016 when v1beta9 had yet to be
released. To fix this, I've removed v1beta10 and merged the original
v1beta9->v1beta10 upgrade into the current v1beta8->v1beta9 upgrade.
Should allow #2029 to go through