Skip secret creation/check #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
skip-secret
branch
2 times, most recently
from
c87f62c to
0d5582e
Compare
tejal29
reviewed
Sep 3, 2019
|
@tejal29 Now, this PR only contains the code changes for secret creation |
dgageot
force-pushed
the
skip-secret
branch
3 times, most recently
from
7189721 to
b01d05a
Compare
Fixes GoogleContainerTools#2768 Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
Sep 4, 2019
tejal29
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible for the users to skip the creation/check for an in-cluster secret.
Fix #2768