Single way of mocking Kubernetes client/dynamic client #2796

dgageot · 2019-09-03T20:38:26Z

Signed-off-by: David Gageot david@gageot.net

codecov · 2019-09-03T20:50:38Z

Codecov Report

Merging #2796 into master will not change coverage.
The diff coverage is 31.57%.

Impacted Files	Coverage Δ
pkg/skaffold/kubernetes/log.go	`38.26% <ø> (ø)`	⬆️
pkg/skaffold/deploy/status_check.go	`63.23% <0%> (ø)`	⬆️
pkg/skaffold/build/cluster/secret.go	`0% <0%> (ø)`	⬆️
pkg/skaffold/build/cluster/sources/localdir.go	`43.47% <0%> (ø)`	⬆️
pkg/skaffold/build/cluster/kaniko.go	`46.26% <0%> (ø)`	⬆️
pkg/skaffold/kubernetes/owner.go	`87.5% <100%> (ø)`	⬆️
pkg/skaffold/sync/sync.go	`75.2% <100%> (ø)`	⬆️
pkg/skaffold/deploy/labels.go	`15.85% <33.33%> (ø)`	⬆️
pkg/skaffold/kubernetes/client.go	`40% <50%> (ø)`	⬆️
...ffold/kubernetes/portforward/resource_forwarder.go	`88% <66.66%> (ø)`	⬆️

Signed-off-by: David Gageot <david@gageot.net>

dgageot requested review from balopat, nkubala, priyawadhwa and tejal29 as code owners September 3, 2019 20:38

googlebot added the cla: yes label Sep 3, 2019

dgageot mentioned this pull request Sep 3, 2019

Skip secret creation/check #2783

Merged

dgageot force-pushed the refacgor-clientset branch from 95bcad7 to 2163bfe Compare September 4, 2019 04:48

balopat approved these changes Sep 4, 2019

View reviewed changes

balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019

kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019

Single way of mocking Kubernetes client/dynamic client

3ca05c0

Signed-off-by: David Gageot <david@gageot.net>

dgageot force-pushed the refacgor-clientset branch from 2163bfe to 3ca05c0 Compare September 4, 2019 06:38

balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019

dgageot merged commit 47cf0d5 into GoogleContainerTools:master Sep 4, 2019