Improve error output when kompose fails #3299
Conversation
Codecov Report
|
dgageot
force-pushed
the
improve-err-output
branch
from
4b6d8a0 to
2441c36
Compare
+ Improve error when compose fails + Check if the compose-file exists + Add test Fix GoogleContainerTools#3288 Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
improve-err-output
branch
from
2441c36 to
d2ae2e8
Compare
| // runKompose runs the `kompose` CLI before running skaffold init | ||
| func runKompose(ctx context.Context, composeFile string) error { | ||
| if _, err := os.Stat(composeFile); os.IsNotExist(err) { | ||
| return err |
There was a problem hiding this comment.
Does err include the filename? Should this be wrapped with unable to find composeFile? Or should we just continue down into kompose and let it show an error?
There was a problem hiding this comment.
It'll show the filename
There was a problem hiding this comment.
It'll show the filename as is
| @@ -74,7 +74,7 @@ func (*Commander) RunCmdOut(cmd *exec.Cmd) ([]byte, error) { | |||
|
|
|||
| err = cmd.Wait() | |||
| if err != nil { | |||
| return stdout, errors.Wrapf(err, "Running %s: stdout %s, stderr: %s, err: %v", cmd.Args, stdout, stderr, err) | |||
| return stdout, errors.Wrapf(err, "Running %s\n - stdout: %s\n - stderr: %s", cmd.Args, stdout, stderr) | |||
There was a problem hiding this comment.
Embedding newlines doesn't seem great. It feels like this should be an object.
There was a problem hiding this comment.
We could do that. And it would have an Error() function that embeds newlines...
I'd rather keep this simple form
There was a problem hiding this comment.
And that object would have an Error() function with that string... I'd rather keep this simple form
util.RunCmdOut()in case of error.Before:
After:
Signed-off-by: David Gageot david@gageot.net