Identify minikube cluster for any profile name

[gsquared94]

Fixes #3668

Description

Currently we need to explicitly specify the minikube profile name as a skaffold flag or limit it to only 'minikube'. This PR introduces several checks for detecting a minikube cluster so that the flag will no longer be required and we can name the cluster anything.
We check:

• The context is 'minikube', or
• The k8s nodes have a minikube label (refer label minikube nodes kubernetes/minikube#6717), or
• The cluster certificate path is within the ~/.minikube directory (refer this comment), or
• The minikube profile list returns a config name matching the context, and
• If the minikube driver is a VM then the node IP should also match the k8s api server url

[codecov]

Codecov Report

Merging #4701 into master will decrease coverage by 0.02%.
The diff coverage is 60.37%.

@@            Coverage Diff             @@
##           master    #4701      +/-   ##
==========================================
- Coverage   73.42%   73.39%   -0.03%     
==========================================
  Files         343      344       +1     
  Lines       13560    13669     +109     
==========================================
+ Hits         9957    10033      +76     
- Misses       2980     3002      +22     
- Partials      623      634      +11     

Impacted Files	Coverage Δ
pkg/skaffold/kubernetes/context/context.go	71.42% <0.00%> (-13.94%)	⬇️
pkg/skaffold/docker/client.go	82.95% <12.50%> (+3.57%)	⬆️
pkg/skaffold/util/util.go	86.07% <60.00%> (-0.86%)	⬇️
pkg/skaffold/cluster/minikube.go	68.75% <68.75%> (ø)
pkg/skaffold/config/util.go	69.31% <100.00%> (ø)
cmd/skaffold/app/skaffold.go	83.33% <0.00%> (-16.67%)	⬇️
pkg/skaffold/deploy/kpt.go	84.27% <0.00%> (+1.41%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54a62b...23d9edd. Read the comment docs.

[tejal29]

Please create follow issue to deprecate --minikube-profile #3668

[tejal29]

few nit changes to simply the code

[gsquared94]

few nit changes to simply the code

Hopefully addressed all of them.

[gsquared94]

Please create follow issue to deprecate --minikube-profile #3668

Done. #4709

[briandealwis]

Querying the API server is just too expensive — we have some users developing against a cluster on the other side of the world. I thought @tstromberg's suggestion was to load up the kubeconfig files and look at the corresponding cluster's certificate-authority to see if it was in ~/.minikube:

    certificate-authority: /Users/bdealwis/.minikube/ca.crt

[gsquared94]

Querying the API server is just too expensive — we have some users developing against a cluster on the other side of the world. I thought @tstromberg's suggestion was to load up the kubeconfig files and look at the corresponding cluster's certificate-authority to see if it was in ~/.minikube:

    certificate-authority: /Users/bdealwis/.minikube/ca.crt

@briandealwis, I implemented this approach and removed the label checker. Although the label checker was a very deterministic check and we could have cached the result to not have to run it multiple times. Maybe we can revisit if current set of heuristics don't prove sufficient.

[tejal29]

one nit.
And follow up with a PR for parsing error codes.

[briandealwis]

A I noticed a few issues that should be fixed.

[gsquared94]

A I noticed a few issues that should be fixed.

Fixed them in follow up PR #4742