Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain minikube detection #6512

Merged
merged 1 commit into from
Aug 26, 2021
Merged

docs: explain minikube detection #6512

merged 1 commit into from
Aug 26, 2021

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Aug 25, 2021

Fixes: #4701

Description
Also explaining how to find current context as many k8s newbies might not know
this. It's also worth debating calling this term "kubectl context" instead of
"kubernetes context", as Kubernetes does not have this notion, only kubectl
does.

User facing changes (remove if N/A)
Started using <sup> tag which rendered larger than the main body font.

image

@ahmetb ahmetb requested a review from a team as a code owner August 25, 2021 18:30
@ahmetb ahmetb requested a review from briandealwis August 25, 2021 18:30
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@ahmetb ahmetb requested review from gsquared94 and removed request for briandealwis August 25, 2021 18:30
Also explaining how to find current context as many k8s newbies might not know
this. It's also worth debating calling this term "kubectl context" instead of
"kubernetes context", as Kubernetes does not have this notion, only kubectl
does.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #6512 (6901ab7) into main (997edc8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6512      +/-   ##
==========================================
+ Coverage   70.43%   70.45%   +0.01%     
==========================================
  Files         515      515              
  Lines       23127    23142      +15     
==========================================
+ Hits        16289    16304      +15     
- Misses       5780     5782       +2     
+ Partials     1058     1056       -2     
Impacted Files Coverage Δ
pkg/skaffold/event/v2/event.go 84.58% <0.00%> (-0.06%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/event/v2/build.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/deploy.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/logger.go 76.27% <0.00%> (ø)
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (ø)
.../skaffold/kubernetes/status/resource/deployment.go 83.85% <0.00%> (ø)
pkg/skaffold/docker/image.go 66.55% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3839f4...6901ab7. Read the comment docs.

@MarlonGamez MarlonGamez added the docs-modifications runs the docs preview service on the given PR label Aug 26, 2021
@container-tools-bot
Copy link

Please visit http://34.94.56.85:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Aug 26, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants