Fix race condition when running tests for pkg/skaffold/instrumentation #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,7 @@ type ExitCoder interface { | |||
| } | |||
|
|
|||
| func main() { | |||
| instrumentation.SetOnlineStatus() | |||
There was a problem hiding this comment.
IMHO we should be pinging a server when the user has disable telemetry.
There was a problem hiding this comment.
The function checks if the user has metrics collection enabled and pings/doesn't ping based off of that. This is done by checking the value of the shouldExportMetrics package variable
Codecov Report
@@ Coverage Diff @@
## master #5267 +/- ##
==========================================
- Coverage 71.90% 71.87% -0.04%
==========================================
Files 388 388
Lines 14063 14064 +1
==========================================
- Hits 10112 10108 -4
- Misses 3210 3214 +4
- Partials 741 742 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition that can occur when running tests for pkg/skaffold/instrumentation. To fix the issue of two threads accessing the
isOnlinevariable, I've moved the responsibility of checking if the user is online to a new function and am calling that in skaffold'smain()