-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update otel libs from v0.13.0 -> v0.20.0 #5757
update otel libs from v0.13.0 -> v0.20.0 #5757
Conversation
3b83e5d
to
ab10f92
Compare
cmd/skaffold/skaffold.go
Outdated
"go.opentelemetry.io/otel" | ||
"go.opentelemetry.io/otel/exporters/stdout" | ||
sdktrace "go.opentelemetry.io/otel/sdk/trace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these 3rd party libs need to be in the 3rd party import block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is fixed now using gci
tool
f4455e9
to
25242e4
Compare
25242e4
to
134cb0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5757 +/- ##
==========================================
- Coverage 70.87% 70.67% -0.21%
==========================================
Files 421 423 +2
Lines 16091 16165 +74
==========================================
+ Hits 11405 11425 +20
- Misses 3850 3900 +50
- Partials 836 840 +4
Continue to review full report at Codecov.
|
What is the problem being solved? Part of GoogleContainerTools#5756, adding opentelemetry trace information to skaffold commands. Updating out libs to the latest otel version adds additional useful functionality for tracing. Why is this the best approach? This approach uses go mod (updated via "go get <pkg>") and minor API changes to our otel API usage for the update. What other approaches did you consider? N/A What side effects will this approach have? There shouldn't be any side effects w/ this approach, the changes to otel's API were renaming/moving things (packages, functions, etc.). The only option removed was stdout Quantile aggregation (stdout.WithQuantiles) but I do not think this will have side effects. See open-telemetry/opentelemetry-go@49f699d#diff-2b283a7fb9f9b66e31a2b51a9ae9cad3599650a633f02fea9a956c4f6a714c6c What future work remains to be done? N/A
134cb0d
to
e3d2d9d
Compare
Can you verify with |
The Quantile piece is only used for the stdout exporter (only used locally via env var |
What is the problem being solved?
Part of #5756, adding opentelemetry trace information to skaffold commands. Updating out libs to the latest otel version adds additional useful functionality for tracing.
Why is this the best approach?
This approach uses go mod (updated via "go get ") and minor API changes to our otel API usage for the update.
What other approaches did you consider?
N/A
What side effects will this approach have?
There shouldn't be any side effects w/ this approach, the changes to otel's API were renaming/moving things (packages, functions, etc.). The only option removed was stdout Quantile aggregation (stdout.WithQuantiles) but I do not think this will have side effects. See open-telemetry/opentelemetry-go@49f699d#diff-2b283a7fb9f9b66e31a2b51a9ae9cad3599650a633f02fea9a956c4f6a714c6c
What future work remains to be done?
N/A