-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add survey config and framework to show feature surveys to skaffold users. #6185
Add survey config and framework to show feature surveys to skaffold users. #6185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6185 +/- ##
==========================================
- Coverage 71.12% 71.08% -0.04%
==========================================
Files 483 484 +1
Lines 21549 21589 +40
==========================================
+ Hits 15326 15346 +20
- Misses 5246 5262 +16
- Partials 977 981 +4
Continue to review full report at Codecov.
|
cmd/skaffold/app/cmd/flags.go
Outdated
{ | ||
Name: "id", | ||
Usage: "Survey id for survey command to open.", | ||
Value: &surveyID, | ||
DefValue: constants.HaTS, | ||
FlagAddMethod: "StringVar", | ||
DefinedOn: []string{"survey"}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this argument isn't used on other commands, we can just move this into NewCmdSurvey()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
ef9f309
to
1b1471f
Compare
relates to #6166
Should merge after : #6186
In this PR, implement first 2 tasks mentioned in the design proposal.
survey.config
struct to represent a survey-id
flag toskaffold survey
command==== Testing notes =====