-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design proposal to show user survey other than Hats #6186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6186 +/- ##
=======================================
Coverage 71.09% 71.10%
=======================================
Files 483 483
Lines 21549 21549
=======================================
+ Hits 15321 15323 +2
+ Misses 5248 5247 -1
+ Partials 980 979 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few suggestions and very minor nits.
{ | ||
id: helmID, | ||
expiresAt: time.Date(2021, time.August, 14, 00, 00, 00, 0, time.UTC), | ||
isRelevantFn: func(cfgs []util.VersionedConfig) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also provide the command name? So for example, we could solicit for feedback on test
or debug
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep!
``` | ||
|
||
### How to prompt users to take user surveys | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe show an example of how the current HaTS prompt looks like, and how the proposal will look like.
Co-authored-by: Brian de Alwis <bsd@acm.org>
related to #6166
This is a design proposal to show user survey (other than Hats) to skaffold users.