docs: Add Docker port-forwarding note #7176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change documents the settings necessary for port forwarding when deploying to Docker. Skaffold [does not publish](https://github.com/nkubala/skaffold/blob/16b931d138b6f10c18dfc04a4f8ca5057d612fe6/pkg/skaffold/deploy/docker/port.go#L94) user-defined port forwards to the Docker daemon unless `resourceType` is set to `container`.
MarlonGamez
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks for contributing to these docs @datumest ! It's much appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change documents the settings necessary for port forwarding when deploying to Docker.
Skaffold does not publish user-defined port forwards to the Docker daemon unless
resourceTypeis set tocontainer.Fixes: #7175
Description
Docker port forwarding is currently undocumented, and required a little code reading to get working properly. This change documents a new
resourceType,container, which the Docker deploy code checks for.