Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially implement the elements panel #266

Merged
merged 15 commits into from
Feb 27, 2020
Merged

Partially implement the elements panel #266

merged 15 commits into from
Feb 27, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Feb 8, 2020 •
edited
Loading

Partial for #29

Changes

  • Adds a helper for creating transparent colors
  • Improves styling for the media library and fixes minor glitch
  • Implements UI for the font presets (functional)
  • Implements a shape library using existing masks (based on Prototype of clipping masks #246 )

Screen Shot 2020-02-07 at 10 38 46 PM

Screen Shot 2020-02-07 at 10 39 00 PM

Screen Shot 2020-02-07 at 10 39 14 PM

swissspidy
swissspidy reviewed Feb 8, 2020
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, nice enhancement! Only a few minor comments.

@spacedmonkey spacedmonkey self-requested a review February 10, 2020 13:44
spacedmonkey
spacedmonkey suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning behind putting element changes and media library changes into one ticket has confused me. Please break this up into two PRs and have ticket linked to those changes. Also when you create the PR for the media library, please add me as a reviewer.

@spacedmonkey
Copy link
Contributor

Why whole PR is confusing, why rewrite the media upload button, it was working fine...

@swissspidy
Copy link
Collaborator

why rewrite the media upload button, it was working fine...

See discussion at https://github.com/google/web-stories-wp/pull/266/files#r376721806

spacedmonkey
spacedmonkey reviewed Feb 14, 2020
View reviewed changes
assets/src/edit-story/components/mediaPicker/useMediaPicker.js
onSelect,
onClose,
type,
export default function useMediaPicker({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being refactored, you may want to look at this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @spacedmonkey can you elaborate on this?

@spacedmonkey spacedmonkey mentioned this pull request Feb 14, 2020
Closed
swissspidy
swissspidy reviewed Feb 21, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
swissspidy
swissspidy approved these changes Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits, otherwise looks good.

The elements panel still seems to be in flux though, so I am expecting some changes here in the future.

@barklund barklund mentioned this pull request Feb 21, 2020
Merged
10 tasks
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Feb 25, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2020 •
edited
Loading

Size Change: +927 B (0%)

Total Size: 235 kB

Filename Size Change
assets/css/edit-story.css 189 B +11 B (5%) 🔍
assets/js/edit-story.js 234 kB +916 B (0%)

compressed-size-action

@wassgha wassgha requested a review from dvoytenko February 26, 2020 10:25
@wassgha wassgha mentioned this pull request Feb 27, 2020
Merged
@swissspidy swissspidy changed the title Partially implements the elements panel Partially implement the elements panel Feb 27, 2020
@swissspidy
Copy link
Collaborator

This is a great first step towards the desired end state. Let's create new PRs for anything that isn't included here 👍

@swissspidy swissspidy merged commit 0673e7b into master Feb 27, 2020
@swissspidy swissspidy deleted the libraries branch February 27, 2020 09:12
obetomuniz added a commit that referenced this pull request Feb 27, 2020
@obetomuniz
Merge branch 'master' into design-panel
4f0def5 
* master:
  Set up code owners (#379)
  Open the preview in the same tab (#420)
  Implement correct interactive library tabs (#361)
  New page background panel (#383)
  Partially implement the elements panel (#266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@dvoytenko dvoytenko dvoytenko approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

Assignees
No one assigned
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wassgha @spacedmonkey @swissspidy @barklund @dvoytenko @googlebot