Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up code owners #379

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Set up code owners #379

merged 7 commits into from
Feb 27, 2020

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Feb 24, 2020

Adds certain people as code owners for certain areas.

See https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners for documentation.

See #319.

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Feb 24, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2020

Size Change: +11 kB (4%)

Total Size: 245 kB

Filename Size Change
assets/css/edit-story.css 189 B +11 B (5%) 🔍
assets/js/edit-story.js 244 kB +11 kB (4%)

compressed-size-action

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@swissspidy swissspidy changed the title [WIP] Set up code owners Set up code owners Feb 26, 2020
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-Authored-By: Morten Barklund <morten.barklund@xwp.co>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@swissspidy
Copy link
Collaborator Author

^ @barklund

@barklund
Copy link
Contributor

@googlebot I fixed it.

@swissspidy
Copy link
Collaborator Author

OK well apparently it didn't get it 🙄 Will add it manually at the end.

@swissspidy swissspidy marked this pull request as ready for review February 26, 2020 21:40
@swissspidy
Copy link
Collaborator Author

@dvoytenko @barklund @spacedmonkey @miina WDYT about the proposed code owners config? Potentially noisy or OK?

Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Copy link
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. Let's try it out, and if it becomes too noisy, we can always change it.

I really like the "default reviewer" thing - especially for a growing team.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@swissspidy swissspidy requested a review from dvoytenko February 27, 2020 20:42
@dvoytenko
Copy link
Contributor

LGTM from me, but I believe you should make @pbakaus a global owner as well given the time difference. I'm sure he won't abuse it. Plus, two global owners is definitely better than one.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@swissspidy swissspidy merged commit 546b1b5 into master Feb 27, 2020
@swissspidy swissspidy deleted the add/codeowners branch February 27, 2020 21:19
obetomuniz added a commit that referenced this pull request Feb 27, 2020
* master:
  Set up code owners (#379)
  Open the preview in the same tab (#420)
  Implement correct interactive library tabs (#361)
  New page background panel (#383)
  Partially implement the elements panel (#266)
@swissspidy swissspidy mentioned this pull request Mar 5, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants