-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up code owners #379
Set up code owners #379
Conversation
Size Change: +11 kB (4%) Total Size: 245 kB
|
Co-Authored-By: Morten Barklund <morten.barklund@xwp.co>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
OK well apparently it didn't get it 🙄 Will add it manually at the end. |
@dvoytenko @barklund @spacedmonkey @miina WDYT about the proposed code owners config? Potentially noisy or OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. Let's try it out, and if it becomes too noisy, we can always change it.
I really like the "default reviewer" thing - especially for a growing team.
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
LGTM from me, but I believe you should make @pbakaus a global owner as well given the time difference. I'm sure he won't abuse it. Plus, two global owners is definitely better than one. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Adds certain people as code owners for certain areas.
See https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners for documentation.
See #319.