Editor: Move assets/src/edit-story to story-editor and wp-story-editor packages
#8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor/src directory
mohdsayed
added
the
Type: Infrastructure
mohdsayed
changed the title
assets/src/editor-story to packages/story-editor/srcassets/src/editor-story to packages/story-editor/src
|
When i have moved files in the past,I have used PHPStorm. This find references to files in other places and will try and update the values for you. There will be hardcoded reference in the dashboard, webpack build files and other other places. This PR in it's current state is unmergable as most of the CI is failing. |
I think this is expected, as it's still a draft. |
|
@spacedmonkey Thank you, yes I think I am aware of some of those. This PR doesn't contain any code changes, it only moves the large chunk to packages so that it's easier to review the upcoming PRs with code changes which I will create against this branch. I would finally merge all those PRs in this branch and ensure that CI is passing before we merge it in main. |
mohdsayed
changed the title
assets/src/editor-story to packages/story-editor/srcassets/src/editor-story to packages/story-editor/src
21 tasks
mohdsayed
changed the title
assets/src/editor-story to packages/story-editor/srcassets/src/editor-story to packages/story-editor/src
swissspidy
changed the title
assets/src/editor-story to packages/story-editor/srcassets/src/edit-story to packages/story-editor/src
Co-authored-by: Jonny Harris <jon@spacedmonkey.co.uk>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Size Change: -1.16 MB (-33%) 🎉 Total Size: 2.33 MB
ℹ️ View Unchanged
|
|
@spacedmonkey can you please reply to the CLA bot? |
spacedmonkey
reviewed
Aug 9, 2021
spacedmonkey
reviewed
Aug 9, 2021
spacedmonkey
suggested changes
Aug 9, 2021
spacedmonkey
reviewed
Aug 9, 2021
Did you mean import from design system? |
I asked the same question. #8561 ATM, design-system, editor and dashboard all import the package. Seems a messy. Makes sense to important in just one place. Design-system makes sense to me. |
…package-story-editor
…or` in webpack and other places (#8636) * Change script handle from edit-story to wp-story-editor * Update webpack handle in karma
|
JFI, "PHP Unit Tests / PHP 7.4 - WP trunk (pull_request)" is failing after b9aff55 which is the only PHP change. But I think its not because of this change, it's failing on other PRs having PHP changes too. |
* Remove localStore from edit-story and move to design system * Update all localStore local references to design-system module * Update more local reference of localStore * Mock localStore from design-system package in jest
|
@sayedtaqui It's a known issue, see https://core.trac.wordpress.org/ticket/46149. Tests against trunk are marked as "experimental" in CI (using |
swissspidy
approved these changes
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #8561 +/- ##
===========================================
+ Coverage 61.83% 79.10% +17.26%
===========================================
Files 881 1336 +455
Lines 15193 18959 +3766
===========================================
+ Hits 9395 14998 +5603
+ Misses 5798 3961 -1837
Flags with carried forward coverage won't be shown. Click here to find out more.
|
swissspidy
changed the title
assets/src/edit-story to packages/story-editor/srcassets/src/edit-story to story-editor and wp-story-editor packages
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR only moves
assets/src/editor-storytopackages/story-editor/srcdirectory and does not contain any code changes.Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
QA
This PR can be tested by following these steps:
UAT
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRPartially addresses #6050