Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Change script handle from edit-story to wp-story-editor in webpack and other places #8636

Merged

Conversation

mohdsayed
Copy link
Contributor

@mohdsayed mohdsayed commented Aug 10, 2021

Context

Change script handle from edit-story to wp-story-editor in webpack and other places

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Related :
#6050
#8561 (comment)

@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@mohdsayed mohdsayed added Package: Story Editor /packages/story-editor Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Aug 10, 2021
@mohdsayed mohdsayed self-assigned this Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #8636 (60e73ae) into feature/package-story-editor (d37d3a4) will decrease coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feature/package-story-editor    #8636      +/-   ##
================================================================
- Coverage                         79.17%   77.49%   -1.69%     
================================================================
  Files                              1334     1324      -10     
  Lines                             18918    18847      -71     
================================================================
- Hits                              14979    14605     -374     
- Misses                             3939     4242     +303     
Flag Coverage Δ
karmatests 77.49% <ø> (+0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/dashboard/app/serializers/stories.js 0.00% <0.00%> (-100.00%) ⬇️
...ets/src/dashboard/app/serializers/publisherLogo.js 0.00% <0.00%> (-100.00%) ⬇️
...ts/src/dashboard/app/serializers/savedTemplates.js 0.00% <0.00%> (-100.00%) ⬇️
...editorSettings/adManagement/googleAdSense/index.js 4.44% <0.00%> (-93.34%) ⬇️
...itorSettings/adManagement/googleAdManager/index.js 8.69% <0.00%> (-91.31%) ⬇️
assets/src/dashboard/app/reducer/stories.js 7.69% <0.00%> (-84.62%) ⬇️
assets/src/dashboard/app/api/apiProvider.js 18.18% <0.00%> (-81.82%) ⬇️
assets/src/dashboard/app/reducer/templates.js 9.09% <0.00%> (-77.28%) ⬇️
...dashboard/app/views/savedTemplates/header/index.js 9.09% <0.00%> (-72.73%) ⬇️
assets/src/dashboard/app/api/useStoryApi.js 2.66% <0.00%> (-72.34%) ⬇️
... and 45 more

@mohdsayed mohdsayed changed the title Refactoring: Change script handle from edit-story to wp-story-editor in webpack and other places Refactoring: Change script handle from edit-story to wp-story-editor in webpack and other places Aug 10, 2021
@mohdsayed mohdsayed marked this pull request as ready for review August 10, 2021 06:48
@mohdsayed mohdsayed merged commit ffe6c9a into feature/package-story-editor Aug 10, 2021
@mohdsayed mohdsayed deleted the feature/package-story-editor-part-4 branch August 10, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Story Editor /packages/story-editor Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants