Fix PowerShell path resolution using GetFullPath instead of Join-Path

[Copilot]

• Investigate Windows path resolution test failure in PowerShell integration tests
• Identify root cause: GetFullPath uses process current directory, not PowerShell location
• Implement fix: Use GetFullPath with explicit base path parameter
• Test fix locally - all tests pass on Linux PowerShell
• Update version number to 2025-11-10
• Commit and push changes
• Wait for CI workflow approval and verify tests pass on Windows

Root Cause Analysis

The issue was that [System.IO.Path]::GetFullPath($path) uses the process's current directory ([System.Environment]::CurrentDirectory), not PowerShell's current location (Get-Location).

In Windows GitHub Actions CI:

• PowerShell location: D:\a\copilot_here\copilot_here (checkout directory)
• Process current directory: C:\Users\RUNNER (user home, possibly set by CI environment)

When GetFullPath was called with a relative path, it resolved relative to C:\Users\RUNNER instead of the PowerShell location, causing malformed paths like:

C:\Users\RUNNERC:\Users\runneradmin1\AppData\Local\Temp\...

Solution

Use the two-parameter overload: [System.IO.Path]::GetFullPath($path, $basePath) with explicit base path from (Get-Location).Path. This ensures relative paths are resolved relative to PowerShell's location, not the process current directory.

Changed in three functions:

• Resolve-MountPath (line 62)
• Save-MountToConfig (line 158)
• Remove-MountFromConfig (line 221)

Co-authored-by: Gordon Beeming me@gordonbeeming.com

Original prompt

please help fix again
https://github.com/GordonBeeming/copilot_here/actions/runs/19237543363/job/54991388449

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[GordonBeeming]

@copilot it looks like it's still broken https://github.com/GordonBeeming/copilot_here/actions/runs/19237870130/job/54993155692?pr=7

[Copilot]

Pull Request Overview

This PR improves path resolution safety in the PowerShell script by replacing Join-Path with [System.IO.Path]::GetFullPath() for more reliable absolute path resolution.

• Replaces Join-Path (Get-Location).Path with GetFullPath() in three functions
• Updates version from 2025-11-05.1 to 2025-11-10
• Adds explanatory comments for the path resolution changes

[Copilot]

@copilot it looks like it's still broken https://github.com/GordonBeeming/copilot_here/actions/runs/19237870130/job/54993155692?pr=7

Fixed in commit 15b4c93. The issue was that GetFullPath() uses the process's current directory, not PowerShell's location. On Windows CI, the process current directory was C:\Users\RUNNER while PowerShell was in D:\a\copilot_here\copilot_here, causing path resolution to use the wrong base directory.

Changed to use the two-parameter overload GetFullPath($path, $basePath) with explicit base from Get-Location, ensuring paths are resolved correctly regardless of the process current directory.