Skip to content

Fix PowerShell path resolution using GetFullPath instead of Join-Path #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GordonBeeming merged 4 commits into from
Nov 10, 2025
Merged

Fix PowerShell path resolution using GetFullPath instead of Join-Path #7

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccba20c
Initial plan
Copilot Nov 10, 2025
3c75c46
chore: Report initial plan for fixing Windows path resolution test fa…
Copilot Nov 10, 2025
7620b95
fix: Replace Join-Path with GetFullPath for safer path resolution
Copilot Nov 10, 2025
15b4c93
fix: Use GetFullPath with explicit base path to avoid process current…
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions copilot_here.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ function Resolve-MountPath {
}

# Convert to absolute path if relative
# Use GetFullPath with explicit base path to avoid process current directory issues
if (-not [System.IO.Path]::IsPathRooted($resolvedPath)) {
$resolvedPath = Join-Path (Get-Location).Path $resolvedPath
$resolvedPath = [System.IO.Path]::GetFullPath($resolvedPath, (Get-Location).Path)
}

# Normalize path separators based on platform
Expand Down Expand Up @@ -152,9 +153,9 @@ function Save-MountToConfig {
$expandedPath = $expandedPath.Replace('~', $env:USERPROFILE)

# Convert to absolute if relative
# Use GetFullPath with explicit base path to avoid process current directory issues
if (-not [System.IO.Path]::IsPathRooted($expandedPath)) {
$expandedPath = Join-Path (Get-Location).Path $expandedPath
$expandedPath = [System.IO.Path]::GetFullPath($expandedPath)
$expandedPath = [System.IO.Path]::GetFullPath($expandedPath, (Get-Location).Path)
}

# If in user profile, convert to tilde format
Expand Down Expand Up @@ -215,9 +216,9 @@ function Remove-MountFromConfig {
$expandedPath = $expandedPath.Replace('~', $env:USERPROFILE)

# Convert to absolute if relative
# Use GetFullPath with explicit base path to avoid process current directory issues
if (-not [System.IO.Path]::IsPathRooted($expandedPath)) {
$expandedPath = Join-Path (Get-Location).Path $expandedPath
$expandedPath = [System.IO.Path]::GetFullPath($expandedPath)
$expandedPath = [System.IO.Path]::GetFullPath($expandedPath, (Get-Location).Path)
}

# If in user profile, convert to tilde format
Expand Down Expand Up @@ -857,7 +858,7 @@ MODES:
Copilot-Here - Safe mode (asks for confirmation before executing)
Copilot-Yolo - YOLO mode (auto-approves all tool usage + all paths)

VERSION: 2025-11-05.1
VERSION: 2025-11-10
REPOSITORY: https://github.com/GordonBeeming/copilot_here
"@
return
Expand Down Expand Up @@ -1079,7 +1080,7 @@ MODES:
Copilot-Here - Safe mode (asks for confirmation before executing)
Copilot-Yolo - YOLO mode (auto-approves all tool usage + all paths)

VERSION: 2025-11-05.1
VERSION: 2025-11-10
REPOSITORY: https://github.com/GordonBeeming/copilot_here
"@
return
Expand Down