BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. #4608

FaisalShaikhHA · 2022-09-23T12:49:48Z

GrapesJS version

I confirm to use the latest version of GrapesJS

What browser are you using?

Version 104.0.5112.101 (Official Build) (arm64)

Reproducible demo link

Screenshot: https://d.pr/i/AyHJyL

Describe the bug

How to reproduce the bug?

Upgrade to the latest grapesjs version.

What is the expected behavior?
Icons under layer manager should be visible.

What is the current behavior?
Icons under layer manager are not visible.

Code of Conduct

I agree to follow this project's Code of Conduct

artf · 2022-09-25T08:14:42Z

Is it what you see also here https://grapesjs.com/demo.html? I see those icons properly 🤔

FaisalShaikhHA · 2022-09-25T12:58:30Z

No, on the demo page icons are visible properly.
To update grapesjs I removed the old version by using npm remove grapesjs and then npm install grapesjs to get the latest version.
I also tried deleting grapesjs folder from node_modules and then used npm install grapesjs but no luck still icons are not rendered.
Used npm install grapesjs@latest as well but the same result.
Going back to version 0.19.4 fixes this issue.

FaisalShaikhHA · 2022-09-26T06:46:33Z

@artf I got the issue this is because of box-sizing CSS but when I try to remove or update this my layout gets distorted.
Count and move icon still not visible.
This does not happen in version 0.19.4 and this css is under style tag so it might be rendered by Grapesjs.

Screen.Capture.on.2022-09-26.at.11-22-06.mp4

FaisalShaikhHA · 2022-09-26T12:39:11Z

@artf this is the css

*,
*::before,
*::after {
  box-sizing: border-box;
}

which is causing problem when I upgrade from 0.19.4 to any greater version.

FaisalShaikhHA · 2022-09-26T13:28:02Z

After adding above mentioned css on the demo page, icons not visible on the demo as well.

artf · 2022-10-18T12:19:18Z

Thanks @FaisalShaikhHA ok I'll fix that as that rule is quite common.

* Up TS add command * Migrate Asset Manager to TS (#4604) * Update assets config * Update index TS * Up TS * Init TS update for assets index * Move assets models to TS * Update AssetView * Update AssetImageView * Update AssetsView * Update FileUploaderView * Update FileUploader * Fix asset tests * Use data-input attribute for events in FileUploader * Up * Update JSDoc config link * Up docs * Typings: Added editor parameter to onStore (#4605) * Typings: Added editor parameter to onStore Added an optional parameter to onStore in the storage manager. This is in accordance with the common use case (https://grapesjs.com/docs/modules/Storage.html#common-use-cases) - HTML code with project data * Typings: OnStore editor non-optional * Propagated editor to onStore in Remote Storage * Up TS * Update TS: ButtonOptions (#4615) * Update TratView * Up TS * FIX: page.select/remove function signature in Type Definitions (#4628) * Update TS: ButtonOptions * Update TS: Page.select function params * Update TS: Page.remove function params * Up Fullscreen * Update preview command * Update icons box-sizing in Layers. Closes #4608 * Update ComponentTextNode escape * Some typescript updates (#4678) * Up tests * Up blocks TS (#4685) * Move to TS blockManager config * Move Block to TS * Update block config * Up block * Move Category to TS * Up Block TS * Move Blocks to TS * Move Categories to TS * Move BlockView to TS * Move CategoryView to TS * Move BlocksView to TS * Remove unused className * Move BlockManager to TS * Clean blockManager * Fix default blocks * Up blocks for docs * Update block properties in d.ts * Move DeviceManager config to TS * Move Device to TS * Move Devices to TS * Move DevicesView to TS * Move DeviceManager to TS * Up device manager constructor * Update file docs for device manager * Clear unused files * Update canvas config TS * Move some common to TS * Move i18n config to TS * Move i18n to TS * Update i18n * Fix tests * Up api docs files * Up config paths in api docs * Move css config to TS * Move CssRule to TS * Move CssRules to TS * Move CssRuleView to TS * Up * Move CssRulesView to TS * Move CssGroupRuleView to TS * Move CssComposer to TS * Fixes for tests * Up for api docs * Fix color picker update on component change. Closes #4691 * Move dom utils to TS * Move Dragger to TS * Up Dragger * Move Droppable to TS * Up Droppable * Move extender to TS * Move fetch to TS * Update fetch and uploader * Move polyfills to TS * Move utils/index to TS * Move keymaster to TS * Move ColorPicker to TS * Move cash to TS * Move Resizer to TS * Remove unused imports * Update resizer init * Refactor utils module * Up TS for utils * Up * Move Keymaps to TS * Move Keymaps config outside * Update docs for keymaps * Update editor TS * Move UndoManagare to TS * Move UndoManager config outside * Up editor TS * Up docs api * [FIX] add missing ccid in component ts definition (#4696) Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Move parser config to TS * Move BrowserParserCss to TS * Move BrowserParserHtml to TS * Move ParserCss to TS * Move ParserHtml to TS * Move Parser module to TS * Update config TS * Update custom css parser TS * Up parserHtml TS * Update parser tests * Up parser doc * Move RTE config to TS * Move RTE to TS * Move RTE module to TS * Up editor ts * Up RTE * Up docs refs * Move code manager config to TS * Move CodeMirrorEditor to TS * Move CssGenerator to TS * Move HTMLGenerator to TS * Move JsGenerator to TS * Move JsonGenerator to TS * Move EditorView to TS * Move CodeManagerModule to TS * Up editor TS * Up tests * Update transform for i18n labels #4698 * Update append with new array * Revert "Update block properties in d.ts" This reverts commit 2abeebd. * Move editor config to TS * Up editor TS * Update EditorModel getConfig * Up editor getConfig * Up editor config * Add LayerManagerConfig * Up editorConfig * Add ModalConfig * Update editor config * Add PanelsConfig * Up editorConfig * Clean editorConfig * Add PageManagerConfig * Add SelectorManagerConfig * Up editorConfig TS * Avoid default style classes with customUI * Up TS * Move ToolbarButton to TS * Update ToolbarButton TS * Move ToolbarButtonView to TS * Move ToolbarView to TS * Add className to toolbar items * Update selector manager * Update editor TS * Up SelectorManager ts * Add id to Device in ts * Up ts * Fix CSS rule creation with at-rule different from media. Closes #4727 * Avoid children selection of already selected components. Closes #4607 * Fix style manager with rules containing !important. Closes #4719 * Fix editable text cursor on touch devices. Closes #4422 * Added a check from config (#4753) Fixes #4743 * Add plugin "Ui Suggest Classes" in the readme (#4746) * Fix trait update with defined classes in attributes. * Remove `_undoexc` from the component JSON. Closes #4763 * minor typo (#4767) * minor typo * minor typo * Bump decode-uri-component from 0.2.0 to 0.2.2 (#4772) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add and use getPropAttribute in ParserHtml * Build Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jamie Stivala <jamiestivala@gmail.com> Co-authored-by: Jeff Wilkerson <stljeff1@users.noreply.github.com> Co-authored-by: Ian Leue <ian@braze.com> Co-authored-by: Singwai Chan <c.singwai@gmail.com> Co-authored-by: Jonathan <4421818+JonathanRiche@users.noreply.github.com> Co-authored-by: Alex Hoyau <a.hoyau@silexlabs.org> Co-authored-by: Alex Greif <agreif@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

FaisalShaikhHA changed the title ~~BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons in layer manager not visible.~~ BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. Sep 23, 2022

artf added the more-information-needed label Sep 25, 2022

artf removed the more-information-needed label Oct 18, 2022

artf closed this as completed in e2a8b8b Oct 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. #4608

BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. #4608

FaisalShaikhHA commented Sep 23, 2022

artf commented Sep 25, 2022

FaisalShaikhHA commented Sep 25, 2022 •

edited

Loading

FaisalShaikhHA commented Sep 26, 2022 •

edited

Loading

FaisalShaikhHA commented Sep 26, 2022 •

edited

Loading

FaisalShaikhHA commented Sep 26, 2022

artf commented Oct 18, 2022

BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. #4608

BUG: After upgrading from 0.19.4 to latest version 0.20.1, icons under layer manager not visible. #4608

Comments

FaisalShaikhHA commented Sep 23, 2022

GrapesJS version

What browser are you using?

Reproducible demo link

Describe the bug

Code of Conduct

artf commented Sep 25, 2022

FaisalShaikhHA commented Sep 25, 2022 • edited Loading

FaisalShaikhHA commented Sep 26, 2022 • edited Loading

FaisalShaikhHA commented Sep 26, 2022 • edited Loading

FaisalShaikhHA commented Sep 26, 2022

artf commented Oct 18, 2022

FaisalShaikhHA commented Sep 25, 2022 •

edited

Loading

FaisalShaikhHA commented Sep 26, 2022 •

edited

Loading

FaisalShaikhHA commented Sep 26, 2022 •

edited

Loading