Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: #4727

Closed
2 tasks done
dreamsight opened this issue Nov 12, 2022 · 0 comments
Closed
2 tasks done

BUG: #4727

dreamsight opened this issue Nov 12, 2022 · 0 comments
Labels

Comments

@dreamsight
Copy link

dreamsight commented Nov 12, 2022

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Version 107.0.5304.107 (Official Build) (64-bit) Chrome

Reproducible demo link

NO NEED anyone can reproduce

Describe the bug

when saving HTML and CSS the program formats Converts CSS
i.e. "@Keyframes slide {"
TO
"@media slide{"

this renders the CSS slider code useless you can test this yourself by simply loading the "@Keyframes slide" CSS in the canvas area then viewing the code conversion.

I have not found the reason for this yet but if anyone has a tip please point me in the right direction :)

EXAMPLE BELOW

@Keyframes slide {
0%,15%{margin-left:0%}
20%,35%{margin-left:-100%}
40%,55%{margin-left:-200%}
60%,75%{margin-left:-300%}
80%,95%{margin-left:-400%}
}
TO:
@media slide{
0%, 15%{
margin-left:0%;
}
20%, 35%{
margin-left:-100%;
}
40%, 55%{
margin-left:-200%;
}
60%, 75%{
margin-left:-300%;
}
80%, 95%{
margin-left:-400%;
}
}
regards
Paul

Code of Conduct

  • I agree to follow this project's Code of Conduct
@artf artf added the bug label Nov 17, 2022
@artf artf closed this as completed in 0f4f38a Nov 17, 2022
artf added a commit that referenced this issue Dec 16, 2022
* Up TS add command

* Migrate Asset Manager to TS (#4604)

* Update assets config

* Update index TS

* Up TS

* Init TS update for assets index

* Move assets models to TS

* Update AssetView

* Update AssetImageView

* Update AssetsView

* Update FileUploaderView

* Update FileUploader

* Fix asset tests

* Use data-input attribute for events in FileUploader

* Up

* Update JSDoc config link

* Up docs

* Typings: Added editor parameter to onStore (#4605)

* Typings: Added editor parameter to onStore 

Added an optional parameter to onStore in the storage manager.  This is in accordance with the common use case  (https://grapesjs.com/docs/modules/Storage.html#common-use-cases) - HTML code with project data

* Typings: OnStore editor non-optional

* Propagated editor to onStore in Remote Storage

* Up TS

* Update TS: ButtonOptions (#4615)

* Update TratView

* Up TS

* FIX: page.select/remove function signature in Type Definitions (#4628)

* Update TS: ButtonOptions

* Update TS: Page.select function params

* Update TS: Page.remove function params

* Up Fullscreen

* Update preview command

* Update icons box-sizing in Layers. Closes #4608

* Update ComponentTextNode escape

* Some typescript updates (#4678)

* Up tests

* Up blocks TS (#4685)

* Move to TS blockManager config

* Move Block to TS

* Update block config

* Up block

* Move Category to TS

* Up Block TS

* Move Blocks to TS

* Move Categories to TS

* Move BlockView to TS

* Move CategoryView to TS

* Move BlocksView to TS

* Remove unused className

* Move BlockManager to TS

* Clean blockManager

* Fix default blocks

* Up blocks for docs

* Update block properties in d.ts

* Move DeviceManager config to TS

* Move Device to TS

* Move Devices to TS

* Move DevicesView to TS

* Move DeviceManager to TS

* Up device manager constructor

* Update file docs for device manager

* Clear unused files

* Update canvas config TS

* Move some common to TS

* Move i18n config to TS

* Move i18n to TS

* Update i18n

* Fix tests

* Up api docs files

* Up config paths in api docs

* Move css config to TS

* Move CssRule to TS

* Move CssRules to TS

* Move CssRuleView to TS

* Up

* Move CssRulesView to TS

* Move CssGroupRuleView to TS

* Move CssComposer to TS

* Fixes for tests

* Up for api docs

* Fix color picker update on component change. Closes #4691

* Move dom utils to TS

* Move Dragger to TS

* Up Dragger

* Move Droppable to TS

* Up Droppable

* Move extender to TS

* Move fetch to TS

* Update fetch and uploader

* Move polyfills to TS

* Move utils/index to TS

* Move keymaster to TS

* Move ColorPicker to TS

* Move cash to TS

* Move Resizer to TS

* Remove unused imports

* Update resizer init

* Refactor utils module

* Up TS for utils

* Up

* Move Keymaps to TS

* Move Keymaps config outside

* Update docs for keymaps

* Update editor TS

* Move UndoManagare to TS

* Move UndoManager config outside

* Up editor TS

* Up docs api

* [FIX] add missing ccid in component ts definition (#4696)

Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>

* Move parser config to TS

* Move BrowserParserCss to TS

* Move BrowserParserHtml to TS

* Move ParserCss to TS

* Move ParserHtml to TS

* Move Parser module to TS

* Update config TS

* Update custom css parser TS

* Up parserHtml TS

* Update parser tests

* Up parser doc

* Move RTE config to TS

* Move RTE to TS

* Move RTE module to TS

* Up editor ts

* Up RTE

* Up docs refs

* Move code manager config to TS

* Move CodeMirrorEditor to TS

* Move CssGenerator to TS

* Move HTMLGenerator to TS

* Move JsGenerator to TS

* Move JsonGenerator to TS

* Move EditorView to TS

* Move CodeManagerModule to TS

* Up editor TS

* Up tests

* Update transform for i18n labels #4698

* Update append with new array

* Revert "Update block properties in d.ts"

This reverts commit 2abeebd.

* Move editor config to TS

* Up editor TS

* Update EditorModel getConfig

* Up editor getConfig

* Up editor config

* Add LayerManagerConfig

* Up editorConfig

* Add ModalConfig

* Update editor config

* Add PanelsConfig

* Up editorConfig

* Clean editorConfig

* Add PageManagerConfig

* Add SelectorManagerConfig

* Up editorConfig TS

* Avoid default style classes with customUI

* Up TS

* Move ToolbarButton to TS

* Update ToolbarButton TS

* Move ToolbarButtonView to TS

* Move ToolbarView to TS

* Add className to toolbar items

* Update selector manager

* Update editor TS

* Up SelectorManager ts

* Add id to Device in ts

* Up ts

* Fix CSS rule creation with at-rule different from media. Closes #4727

* Avoid children selection of already selected components. Closes #4607

* Fix style manager with rules containing !important. Closes #4719

* Fix editable text cursor on touch devices. Closes #4422

* Added a check from config (#4753) Fixes #4743

* Add plugin "Ui Suggest Classes" in the readme (#4746)

* Fix trait update with defined classes in attributes.

* Remove `_undoexc` from the component JSON. Closes #4763

* minor typo (#4767)

* minor typo

* minor typo

* Bump decode-uri-component from 0.2.0 to 0.2.2 (#4772)

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add and use getPropAttribute in ParserHtml

* Build

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jamie Stivala <jamiestivala@gmail.com>
Co-authored-by: Jeff Wilkerson <stljeff1@users.noreply.github.com>
Co-authored-by: Ian Leue <ian@braze.com>
Co-authored-by: Singwai Chan <c.singwai@gmail.com>
Co-authored-by: Jonathan <4421818+JonathanRiche@users.noreply.github.com>
Co-authored-by: Alex Hoyau <a.hoyau@silexlabs.org>
Co-authored-by: Alex Greif <agreif@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants