Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: v2 rho prepare #15

Merged
merged 11 commits into from
Aug 2, 2022
Merged

build!: v2 rho prepare #15

merged 11 commits into from
Aug 2, 2022

Conversation

dongsam
Copy link
Collaborator

@dongsam dongsam commented May 13, 2022

Description

  • bump cosmos-sdk to v0.46.x ( currently v0.46.0 )
  • remove swap functionality ( circuit breaker enabled and deprecated on cosmos-hub )
  • bump package name to liquididty/v2

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #15 (008dbf6) into master (360cec4) will decrease coverage by 6.85%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   33.24%   26.38%   -6.86%     
==========================================
  Files          44       42       -2     
  Lines       12503    11895     -608     
==========================================
- Hits         4156     3138    -1018     
- Misses       7855     8418     +563     
+ Partials      492      339     -153     
Impacted Files Coverage Δ
x/liquidity/abci.go 100.00% <ø> (ø)
x/liquidity/client/cli/query.go 66.49% <ø> (-17.77%) ⬇️
x/liquidity/genesis.go 100.00% <ø> (ø)
x/liquidity/handler.go 100.00% <ø> (ø)
x/liquidity/keeper/genesis.go 92.59% <ø> (ø)
x/liquidity/keeper/grpc_query.go 54.94% <ø> (-2.20%) ⬇️
x/liquidity/keeper/migration.go 50.00% <ø> (ø)
x/liquidity/keeper/msg_server.go 2.59% <ø> (+0.61%) ⬆️
x/liquidity/keeper/querier.go 72.41% <ø> (ø)
x/liquidity/keeper/store.go 70.05% <ø> (-20.06%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360cec4...008dbf6. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review May 16, 2022 02:08
@yaruwangway
Copy link

Hi @dongsam, can you please bump to sdk 0.46-rc1 ? we need this for rho, Thank you!

@dongsam
Copy link
Collaborator Author

dongsam commented Jun 3, 2022

Hi @dongsam, can you please bump to sdk 0.46-rc1 ? we need this for rho, Thank you!

Hi @yaruwangway, I just released v2.0.0-rc1 which is based sdk 0.46.0-rc1

@dongsam dongsam mentioned this pull request Jul 11, 2022
9 tasks
…repare

* commit '360cec48ac291bc85acceb80f824f82e532009f0':
  build: bump go 1.18
  build: bump cosmos-sdk to v0.45.6
Copy link
Collaborator

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good to me

@dongsam
Copy link
Collaborator Author

dongsam commented Jul 27, 2022

First of all, we released v2.0.0-rc3 based on the PR branch. We will release official v2.0.0 after confirming that there is no conflict or issue with other modules in the Rho upgrade PR

@dongsam dongsam merged commit ba7b225 into master Aug 2, 2022
@dongsam
Copy link
Collaborator Author

dongsam commented Aug 2, 2022

https://github.com/Gravity-Devs/liquidity/releases/tag/v2.0.0
final v2.0.0 released, which is using cosmos-sdk v0.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants