sdk 46 rc2 #16
Closed
sdk 46 rc2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
commented
May 27, 2022
x/liquidity/types/utils.go
Outdated
| @@ -88,7 +89,7 @@ func GetOfferCoinFee(offerCoin sdk.Coin, swapFeeRate sdk.Dec) sdk.Coin { | |||
| } | |||
| // apply half-ratio swap fee rate and ceiling | |||
| // see https://github.com/tendermint/liquidity/issues/41 for details | |||
| return sdk.NewCoin(offerCoin.Denom, offerCoin.Amount.ToDec().Mul(swapFeeRate.QuoInt64(2)).Ceil().TruncateInt()) // Ceil(offerCoin.Amount * (swapFeeRate/2)) | |||
| return sdk.NewCoin(offerCoin.Denom, math.Dec(offerCoin.Amount.Mul(swapFeeRate.QuoInt64(2)).Ceil().TruncateInt())) // Ceil(offerCoin.Amount * (swapFeeRate/2)) NOTE: I COULD HAVE MADE A BUG HERE IN THE DECIMAL CONVERSION. | |||
There was a problem hiding this comment.
this is the line I am unsure of, sorry 'bout that.
Definitely wanted to flag it, too, looks like it's an important one. basically, it is now looking for an cosmosdk.io/math.Int
faddat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey guys, I think that I made most of the changes successfully.
That said, I am not sure how to apply
cosmossdk.io/mathtoBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes