[WIP] Single entry in lightbox #2055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, it's very proof-of-concept, but I'm loving that this is finally working.
This allows us to override these values without modifying any other code. These are placeholders and should be reviewed. Also, should this be placed in GV\REST\Request() instead?
|
Closing in favor of work done in a separate PR. |
mrcasual
added a commit
that referenced
this pull request
Sep 25, 2024
_(work was initially done in #2055 ## To enable: 1. Add a "Link to Single Entry" field 2. Open field settings 3. Check the "Open in a lightbox?" checkbox 4. Save the View  ## Big things to work on: - [x] Allow for Next/Previous and Single Entry navigation options. - [x] Remove the `<— Go back` link - [x] Remove single entry widget header hooks `add_action( 'gravityview/template/before', array( $this, 'render_widget_hooks' ) );` (started work here: `class-gv-request-rest.php` `Request::is_entry()`) - [x] When "open in lightbox" is enabled, disable "open in new window" option. - [x] Make sure to embed Custom CSS and Custom JS output. - [x] Enable galleries inside modal. - [x] Prevent lightbox links from being indexed. - [x] Edit Entry isn't working. - [ ] Add support for the CSS styles that are in Dashboard Views. ## Questions form #197 * How do we handle updating data? When closing the lightbox, if an entry has been edited, outdated values may be shown. * Will Inline Edit work inside this? 🤯 - If enabled, should we disable Inline Edit? ## To test: - [x] **Single Entry link** - [x] The link does not open in a lightbox when the corresponding field option is not checked. - [x] When "Open in a lightbox?" option is checked, the link opens in a lightbox, allowing navigation left/right between entries. - [x] Edit Entry link opens inside the Single Entry lightbox view. - [x] **Edit Entry link** - [x] The link does not open in a lightbox when the corresponding field option is not checked. - [x] When "open in lightbox" is checked, the link opens in a lightbox, allowing navigation left/right between entries. - [x] Updating the entry works. - [x] After an update, "return to entry" opens the Single Entry layout inside the lightbox. If it has an Edit Entry link, it should open inside the lightbox. - [x] Deleting the entry works. - [x] After deletion, the page should refresh or, if configured in the View Editor under Delete Entry, URL redirection should work. - [x] **Permissions**: only authorized users should be able to view, edit and delete entries. 💾 [Build file](https://www.dropbox.com/scl/fi/fdp5fvj9zm2usa8hmysik/gravityview-2.28.0-49301e324.zip?rlkey=xdty6oork78qputtuqm57bllq&dl=1) (49301e3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work is being done on
includes/extensions/lightbox/.To enable:
Big things to work on
<— Go backlinkadd_action( 'gravityview/template/before', array( $this, 'render_widget_hooks' ) );(started work here:class-gv-request-rest.phpRequest::is_entry())💾 Build file (5f5499e).