-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single entry in lightbox #2136
Single entry in lightbox #2136
Conversation
This is consistent with how we modify the Single Entry field link markup.
68b2734
to
42b9cbf
Compare
@Mwalek, please test and report any issues. |
42b9cbf
to
ba542ad
Compare
@mrcasual @zackkatz I tested this in PHP versions 7.4 and 8.2, here are my results. Each issue is highlighted in the video below: 1. PHP Warnings and Notices on Plugin ActivationWarnings shown during plugin activation.
2. Deprecation Warnings When Clicking "View Details" LinkDeprecation warnings when viewing a single entry.
3. Entire Site Loads Inside Popup When Editing Single EntryEditing a single entry opens the entire site, including the admin bar, inside the popup.
4. Redirect or Refresh Happens Inside the Popup When Deleting an EntryWhen deleting an entry, the redirect or refresh action takes place within the popup instead of across the entire page.
5. Incorrect 'Edit Link Text' When 'Open in a Lightbox' is EnabledThe 'Link to Edit Entry' does not display the correct text when the 'open in a lightbox' option is enabled.
Issue Summary
|
Thanks @mrcasual, of the earlier issues, only issue 4 (Redirect/Refresh Occurs in Popup when deleting an entry) remains. E.g: https://basecamp.try.gravitykit.com/view/lightbox-view-1/ I've also discovered a new issue in Mozilla Firefox. In Firefox, the lightbox is too short when the "edit" link is clicked in the single entry popup. Actual:
Expected:
Issue Summary:
|
@mrcasual many of the remaining issues are related to the "plain" permalink structure, see below. Lightbox opens inside itself when Permalinks are set to "plain" and edit option is clicked
Redirect to external URL doesn't work when Permalinks are set to "plain"
"Redirect to multiple entries" does not work when editing with plain permalink structure
Post name permalink, Firefox: Popup initially short, grows when edit link is clicked
Lightbox is still short in Firefox if permalinks are "plain"
Issue Summary
|
@Mwalek, there's an issue on |
@mrcasual here are a few items:
|
@mrcasual all the issues don't exist in local, except the one below:
https://www.loom.com/share/295efe48a55a4282a204507b92624dbb?sid=8bd1fb01-fa70-4e74-8161-743b87033208 |
@Mwalek, good to hear that there aren't any issues. Please provide the Firefox version as well as the theme that you're using. FF 130 and Twenty Twenty-Four: CleanShot.2024-09-14.at.10.25.58.mp4 |
@mrcasual same as you. Firefox: 130.0 (64-bit) Theme: Twenty Twenty-Four The video you shared has the same behavior as mine. The popup grows when the edit link is clicked. If this is intended, then there are no remaining issues. |
The action is used by Gravity Forms for form submission as well other GV and third-party code.
This works with Ajax and non-Ajax requests
@Mwalek, please test Zack's items + do another test of all features using different permalink structures. Once done, tick all action items from previous comments and, if there are still any issues, consolidate any outstanding items in a new comment. |
@mrcasual I tested all the issues again and nearly everything works as expected. The following problems could be observed though:
Item 3 from Zack's earlier comment has the steps to reproduce:
Except, instead of the page loading recursively, raw HTML text is shown.
Other
|
This should be a separate issue to improve error handling.
Have you tried testing locally? I can't reproduce it since this was addressed in 8c8302f, so I need to make sure it's not specific to the |
@mrcasual thanks, I'll create a separate issue for the email notification error handling. For the raw HTML issue, I was able to reproduce it locally as well: https://www.loom.com/share/acaf65e3a856418e9b8af0ea8f7693ec NB: Make sure you're using AJAX, it works when AJAX is not enabled. |
@mrcasual another issue is that the lightbox does not show up when the setting "Enable lightbox for images" is disabled: https://www.loom.com/share/067f1a5320244c0e89d76329df3a53fe?sid=643b1b76-cc3c-47a2-8c53-f77962c08430 Instead of showing the content in a lightbox, the content opens in a new page with no other content. The lightbox should not be affected by the setting that is only meant for images
|
@mrcasual both issues are resolved! 👌 |
@Mwalek, great, thank you! @zackkatz, do you want to give this PR another try? @rafaehlers and @crbdev, please test as well and report any issues and missing features. |
Will do. I played around with it a bit and it seems great. @mrcasual are you okay if we demo this during our live call next Tuesday? Even if it's not released yet, it's fine. |
@crbdev, I don't see why not. Make sure to test all scenarios to avoid any issues during the live call. |
|
@mrcasual Error when embedding a Gravity Forms form in Single Entry. It looks correct, but submitting the form fails with a JS error when clicking Submit:
|
@zackkatz, form submission should work fine (both @Mwalek and I tested it using the latest release versions of Chrome, FF and Safari). What's your browser and where can I see the error? |
@mrcasual I believe the issue was with a corrupted setup; I exported the form and was unable to reproduce. |
Works great, @mrcasual 👏 |
(work was initially done in #2055)
To enable:
Big things to work on:
<— Go back
linkadd_action( 'gravityview/template/before', array( $this, 'render_widget_hooks' ) );
(started work here:class-gv-request-rest.php
Request::is_entry()
)Questions form #197
To test:
💾 Build file (49301e3).