Fix gelf uncompressed scheme #3
Merged
+6
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was based on lusis/gelfd@79b893a but apparently the scheme was changed for https://github.com/Graylog2/graylog2-server/blob/master/graylog2-server/src/main/java/org/graylog2/inputs/codecs/gelf/GELFMessage.java#L147 i.e. no more magic header. This removes the magic header and also optimize the ReadMessage code a bit i.e. no more temporary buffer to store the uncompressed json. Signed-off-by: Daniel Dao <dqminh@cloudflare.com>
|
ping @mariussturm tested this manually with a container running graylog2 locally. Let me know if this looks right. |
mariussturm
pushed a commit
that referenced
this pull request
Jan 25, 2016
Fix gelf uncompressed scheme
|
Yeah, looks good. Will also do some testing later in the week. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code (#2) was based on lusis/gelfd@79b893a but apparently the scheme was changed for GelfMessage.java i.e. no more magic header.
This removes the magic header and also optimize the ReadMessage code a bit i.e.
no more temporary buffer to store the uncompressed json.