This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
remove uncompressed data magic header #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default to returning uncompressed data without checking for magic header for compliant with graylog2 server. Relevant piece for graylog2 server is at https://github.com/Graylog2/graylog2-server/blob/edd1a66a2f9924e39b217df4c94327a86b8fecab/graylog2-server/src/main/java/org/graylog2/inputs/codecs/gelf/GELFMessage.java#L147 Signed-off-by: Daniel Dao <dqminh@cloudflare.com>
dqminh
force-pushed
the
fix-uncompressed
branch
from
8f588ba to
bd3c3af
Compare
|
+1 on this. The master branch of graylog server no longer uses uncompressed header bytes and this breaks certain gelf libraries, like the underlying go-gelf library for docker, which already made this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default to returning uncompressed data without checking for magic header for
compliant with graylog2 server. Relevant piece for graylog2 server is at
https://github.com/Graylog2/graylog2-server/blob/edd1a66a2f9924e39b217df4c94327a86b8fecab/graylog2-server/src/main/java/org/graylog2/inputs/codecs/gelf/GELFMessage.java#L147