Proposal to make document title dynamic #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a component that takes care of modifying the document title to a given value, and use it in one of the pages as an example. Refs #2834
dennisoelkers
approved these changes
Sep 23, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a component that takes care of modifying the document title (called
DocumentTitlein a very original way). This component should be used in all pages that want to modify the original title, like in the example provided. The reason for doing this in the page level instead ofAppRouter, is that sometimes we will need some data to display in the title that is only loaded with the page.If we want to proceed with this, I can take care of modifying other pages to use
DocumentTitle.Refs #2834