Add document titles #3160
Merged
Add document titles #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 6, 2016 17:44
Use the authentication page to get to LDAP pages. Also delete old (and unused) LDAP pages.
We cannot properly keep the previous title, as component are not necessarily unmounted in the same order they were mounted. Instead of trying to be smart about this, we now reset the page title when `DocumentTitle` is unmounted, and consumers of this component can mount another instance with a different title if they want to customize the title. We can make this a bit smarted in the future if we need to, but right now is good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already did some ground work to add dynamic document titles to our pages, so this PR is taking care of adding titles to all reachable pages in the web interface.
PRs to add titles to each plugin will follow-up.
Refs #2834, #2842.