Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanded chance logic #1644

Merged
merged 7 commits into from
Aug 5, 2024
Merged

expanded chance logic #1644

merged 7 commits into from
Aug 5, 2024

Conversation

screret
Copy link
Member

@screret screret commented Aug 4, 2024

What

adds different ways of computing chanced outputs and ports GregTechCEu/GregTech#2565 with slight tweaks.
also adds an IntProviderIngredient for out/inputting a random amount of items.

Implementation Details

read the original PR desc idk

Outcome

better chance computations &

Additional Information

video (slightly outdated)
video

Potential Compatibility Issues

no breaking changes to outside users as far as I can see 👍

@screret screret requested a review from a team as a code owner August 4, 2024 19:50
@screret
Copy link
Member Author

screret commented Aug 4, 2024

ok so turns out it doesnt embed videos i guess

@YoungOnionMC YoungOnionMC merged commit b42c3d2 into 1.20.1 Aug 5, 2024
2 checks passed
@YoungOnionMC YoungOnionMC deleted the sc/expanded-chance-logic branch August 5, 2024 00:55
@screret screret added the type: refactor Suggestion to refactor a section of code label Aug 16, 2024
screret added a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants