Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use hawkeye license checker #187

Merged
merged 19 commits into from
Jan 20, 2024
Merged

chore: use hawkeye license checker #187

merged 19 commits into from
Jan 20, 2024

Conversation

daviderli614
Copy link
Member

@daviderli614 daviderli614 commented Jan 15, 2024 •
edited
Loading

  1. update golangci-lint version to v1.55.2.
  2. use korandoru/hawkeye@v3 license checker action. hawkeye

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f534d2) 37.91% compared to head (412bcaa) 37.91%.

Files Patch % Lines
pkg/cluster/baremetal/create.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #187   +/-   ##
========================================
  Coverage    37.91%   37.91%           
========================================
  Files           16       16           
  Lines         1295     1295           
========================================
  Hits           491      491           
  Misses         699      699           
  Partials       105      105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daviderli614 daviderli614 requested a review from zyy17 January 16, 2024 08:37
@daviderli614 daviderli614 changed the title fix: failed to start frontend in gtctl playground chore: use hawkeye license checker Jan 18, 2024
@zyy17
Copy link
Collaborator

zyy17 commented Jan 20, 2024

@daviderli614 Can we keep *.go unchanged? The PR seems just modify the comment format of license header.

@zyy17 zyy17 mentioned this pull request Jan 20, 2024
Merged
@zyy17
Copy link
Collaborator

zyy17 commented Jan 20, 2024

@daviderli614 Can we keep *.go unchanged? The PR seems just modify the comment format of license header.

Never mind, it seems reasonable.

zyy17
zyy17 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 1cdc306 into GreptimeTeam:develop Jan 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviderli614 @codecov-commenter @zyy17