Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add frontend start args #188

Merged

Conversation

daviderli614
Copy link
Member

No description provided.

@daviderli614 daviderli614 requested a review from zyy17 January 18, 2024 03:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1cdc306) 37.91% compared to head (476c448) 37.76%.

Files Patch % Lines
pkg/config/baremetal.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    37.91%   37.76%   -0.15%     
===========================================
  Files           16       16              
  Lines         1295     1300       +5     
===========================================
  Hits           491      491              
- Misses         699      704       +5     
  Partials       105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17
Copy link
Collaborator

zyy17 commented Jan 20, 2024

The PR relies on #187.

@daviderli614 daviderli614 merged commit 117cbfb into GreptimeTeam:develop Jan 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants