Capella #4
Merged
Capella #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-miller-0
force-pushed
the
add-tests-docs
branch
from
6b44daa to
068c924
Compare
alex-miller-0
force-pushed
the
capella
branch
from
b986ceb to
89cd78d
Compare
alex-miller-0
force-pushed
the
add-tests-docs
branch
from
068c924 to
b759457
Compare
alex-miller-0
force-pushed
the
capella
branch
2 times, most recently
from
430bd47 to
a563ebc
Compare
alex-miller-0
force-pushed
the
capella
branch
from
a563ebc to
df6d967
Compare
|
Following up on this, I have not done any further development or testing and I am watching this issue as a guide: ethereum/staking-deposit-cli#312 |
alex-miller-0
commented
Feb 6, 2023
alex-miller-0
commented
Feb 27, 2023
|
Unfortunately there appears to be no way to generate a BLS change message statelessly, (i.e. with a random mnemonic) via ethdo: https://github.com/wealdtech/ethdo/blob/master/docs/changingwithdrawalcredentials.md So this is basically blocked until I can generate some test vectors. I will clean up a few things in the mean time |
Signatures matching with reference, but only if validatorRoot is modified and I'm not sure the reference is using the correct root
Apparently this is what should have been used all along, but deposits hard code an empty root because they preceeded Bellatrix
alex-miller-0
commented
Mar 22, 2023
alex-miller-0
commented
Mar 22, 2023
|
Tests are all passing, output data matches that of the official deposit CLI - I'm going to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to generate
SignedBLSToExecutionChangeobjects so that withdrawal credentials can be upgraded from the 0x00 (BLS) version to the 0x01 (execution) type.Generates a JSON object that is equivalent to the official deposit CLI and validates this with several statically generated test vectors.
Closes #2