Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.13.2 - Griddle now fully compatible with React 16 #842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mDibyo
Copy link
Contributor

@mDibyo mDibyo commented Dec 24, 2018

Griddle major version

v1

Changes in this release

@mDibyo
Copy link
Contributor Author

mDibyo commented Dec 24, 2018

@ryanlanciaux and other maintainers: I was able to get master installed by doing
yarn add https://github.com/GriddleGriddle/Griddle.git#49306e7, but would be nice to just have a new package version. :)

UPDATE: A quirk with yarn prevents yarn add from being a feasible approach. yarn add runs the prepare script, but running yarn install for a project depending on the package does not, meaning this approach doesn't work in any deployment environments.

@mDibyo
Copy link
Contributor Author

mDibyo commented Dec 24, 2018

Also, I had missed updating yarn.lock in #839 and #840, and this PR fixes that. (I can create a separate PR for fixing yarn.lock, if you guys would prefer that. )

@mDibyo mDibyo changed the title Release 1.13.2 Release 1.13.2 - makes Griddle fully compatible with React 16 Jan 9, 2019
@mDibyo mDibyo changed the title Release 1.13.2 - makes Griddle fully compatible with React 16 Release 1.13.2 - Griddle now fully compatible with React 16 Jan 9, 2019
@mDibyo
Copy link
Contributor Author

mDibyo commented Jan 9, 2019

@ryanlanciaux @dahlbyk would be super duper nice to get this new version of the package. :) Anything I can do to help with this?

Our team is currently blocked on upgrading to React 16, since the current version of Griddle (v1.13.1) is not "officially" compatible with React 16.
But that issue was resolved when #839 was merged. All we need now is a new version of the package, and we'd rather not depend on a private fork of the package.

@JamesNimlos
Copy link

If using yarn, you can use the package.json#resolutions property to force the nested version resolution. In this case we added the following to our package.json file:

{
  "resolutions": {
    "griddle-react/recompose": "^0.25.1"
  }
}

@docrinehart
Copy link

Referencing #856

@docrinehart
Copy link

docrinehart commented Jul 9, 2019

@ryanlanciaux
This PR is invalidated by #849 , we should be able to close this with the next release.

@LoganArnett
Copy link

Any word on when this will be released?

@Plummat
Copy link

Plummat commented Oct 21, 2019

bump

@beekerstudios
Copy link

Anyway this can get merged so people can upgrade to react 16.x, this is the only thing holding it up it looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants