Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the whole package dependacies to the latest using React 16.8, Webpack 4 #849

Merged
merged 6 commits into from
Jul 2, 2019

Conversation

Debananda
Copy link
Contributor

1.14

Updating react to 16.8 and Webpack 4

Further developments will be easy as the current repository used way too old packages.

Tests are also made intact

@docrinehart
Copy link

@ryanlanciaux I'm looking at the possibility of contributing to Griddle as I've started to run into dependency issues when updating other redux related packages.

This PR would be a nice step forward for maintainability.

@ryanlanciaux
Copy link
Member

@Debananda thank you for adding this! Will try to get some eyes on it now (sorry been beyond swamped).

@docrinehart totally agree. Any chance you have had a second to try this out locally?

@ryanlanciaux ryanlanciaux merged commit a2b67c1 into GriddleGriddle:master Jul 2, 2019
@ryanlanciaux
Copy link
Member

@Debananda Thanks a ton for doing this!

@docrinehart
Copy link

@ryanlanciaux No, I hadn't had a chance to pull it yet. Been pretty swamped myself. We found a workaround for the issue we bumped into, but having this in will surely help long-term, once things settle down.

@Plummat
Copy link

Plummat commented Sep 12, 2019

any updates around this?

@beekerstudios
Copy link

Any update on this, so people using griddle can upgrade to react 16.x?

@Debananda
Copy link
Contributor Author

trying to replace recompose with hooks and react-redux in-house support of useSelector and all. Let me know if any has done any progress on the same so.

@Debananda
Copy link
Contributor Author

@ryanlanciaux, @docrinehart : I have removed most of the recompose usage except from TableHeadingCellContainer and index.tsx in stories. Need some helping hand in removing them and code review. Code is available at https://github.com/Debananda/Griddle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants