v1.13.0 #2
Merged
v1.13.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated `.extend` method should not be called when the modules are imported. The change in the next commit will allow users of the library to upgrade to video.js version 8 where the `.extend` method has been removed. Issue silvermine#152
Users of the library are seeing this warning in the browser console. ``` VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0 ``` Users will now be able to upgrade to Video.js >= 8 where the `.extend` method has been removed. Issue silvermine#152, Related to silvermine#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated
.extendmethod should not be called when the modules are imported. The change in the next commit will allow users of the library to upgrade to video.js version 8 where the.extendmethod has been removed.Issue silvermine#152