Fix navigation bug #438
Merged
Fix navigation bug #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
fix-navigation-bug
branch
from
837e50f
to
8f07cd4
Compare
GuillaumeGomez
force-pushed
the
fix-navigation-bug
branch
from
8f07cd4
to
9ad44b8
Compare
notriddle
reviewed
Feb 23, 2023
Comment on lines
+5
to
+26
| body { | ||
| margin: 0; | ||
| background-color: #eee; | ||
| } | ||
| header { | ||
| background-color: #111; | ||
| width: 100%; | ||
| text-align: center; | ||
| font-size: 1.3em; | ||
| color: #fff; | ||
| } | ||
| .content { | ||
| text-align: center; | ||
| } | ||
| .content > a { | ||
| padding: 5px; | ||
| border: 1px solid #ccc; | ||
| border-radius: 5px; | ||
| background-color: #fff; | ||
| text-decoration: none; | ||
| color: #111; | ||
| } |
There was a problem hiding this comment.
Is any of this actually necessary?
There was a problem hiding this comment.
No, just copied/pasted another file. Could be removed.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 24, 2023
…tion-bug, r=notriddle Fix GUI test navigation bug Following GuillaumeGomez/browser-UI-test#438, we can now remove this `wait-for`. Should help with rust-lang#93784. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 25, 2023
…tion-bug, r=notriddle Fix GUI test navigation bug Following GuillaumeGomez/browser-UI-test#438, we can now remove this `wait-for`. Should help with rust-lang#93784. r? ``@notriddle``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427.