Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GUI test navigation bug #108412

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Fix GUI test navigation bug #108412

merged 2 commits into from
Feb 25, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 23, 2023 •
edited
Loading

Following GuillaumeGomez/browser-UI-test#438, we can now remove this wait-for.

Should help with #93784.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 23, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 23, 2023

📌 Commit 4ff1c4d has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2023
@GuillaumeGomez GuillaumeGomez changed the title Fix gui test navigation bug Fix GUI test navigation bug Feb 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#108412 - GuillaumeGomez:fix-gui-test-naviga…
cd9630c 
…tion-bug, r=notriddle

Fix GUI test navigation bug

Following GuillaumeGomez/browser-UI-test#438, we can now remove this `wait-for`.

Should help with rust-lang#93784.

r? `@notriddle`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 24, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2023
@bors
Auto merge of rust-lang#108450 - matthiaskrgr:rollup-rqvfgu3, r=matth…
31448ba 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108354 (Update `fuchsia-test-runner.py` and docs)
 - rust-lang#108404 (support `x fmt` for sub and outside of rust directories)
 - rust-lang#108407 (docs: use intra-doc links for `Vec::get(_mut)`)
 - rust-lang#108410 (rustdoc: avoid including `<li>` tags in item table short desc)
 - rust-lang#108412 (Fix GUI test navigation bug)
 - rust-lang#108433 (Wrap missing provider message correctly)
 - rust-lang#108434 (Migrate `rustc_hir_analysis` to session diagnostic [Part One])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 47c7d53 into rust-lang:master Feb 25, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 25, 2023
@GuillaumeGomez GuillaumeGomez deleted the fix-gui-test-navigation-bug branch February 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @notriddle @bors @rustbot