Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use intra-doc links for Vec::get(_mut) #108407

Merged
merged 1 commit into from
Feb 25, 2023
Merged

docs: use intra-doc links for Vec::get(_mut) #108407

merged 1 commit into from
Feb 25, 2023

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Feb 23, 2023 •
edited
Loading

Now that #63351 is fixed, there's no reason not to.

CC #75672

@notriddle
docs: use intra-doc links for Vec::get(_mut)
a402cb0 
Now that rust-lang#63351 is fixed, there's no reason not to.
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Feb 24, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2023

📌 Commit a402cb0 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#108407 - notriddle:notriddle/vec-get-mut, r…
ba31bba 
…=thomcc

docs: use intra-doc links for `Vec::get(_mut)`

Now that rust-lang#63351 is fixed, there's no reason not to.

CC rust-lang#75672
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 24, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2023
@bors
Auto merge of rust-lang#108450 - matthiaskrgr:rollup-rqvfgu3, r=matth…
31448ba 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108354 (Update `fuchsia-test-runner.py` and docs)
 - rust-lang#108404 (support `x fmt` for sub and outside of rust directories)
 - rust-lang#108407 (docs: use intra-doc links for `Vec::get(_mut)`)
 - rust-lang#108410 (rustdoc: avoid including `<li>` tags in item table short desc)
 - rust-lang#108412 (Fix GUI test navigation bug)
 - rust-lang#108433 (Wrap missing provider message correctly)
 - rust-lang#108434 (Migrate `rustc_hir_analysis` to session diagnostic [Part One])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7c562ee into rust-lang:master Feb 25, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 25, 2023
@notriddle notriddle deleted the notriddle/vec-get-mut branch February 25, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @rustbot @thomcc @bors