Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no temperature on Raspberry Pi #328

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Fix no temperature on Raspberry Pi #328

merged 2 commits into from
Jun 24, 2020

Conversation

arctic-alpaca
Copy link
Contributor

Should fix #327

@arctic-alpaca arctic-alpaca mentioned this pull request Jun 24, 2020
Closed
GuillaumeGomez
GuillaumeGomez requested changes Jun 24, 2020
View reviewed changes
Copy link
Owner

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one thing to change and it's good to go.

src/linux/component.rs Outdated
)]
));
}
if components.len() != 0 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this check isn't useful anymore: you can just return components.

GuillaumeGomez
GuillaumeGomez approved these changes Jun 24, 2020
View reviewed changes
Copy link
Owner

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeGomez
Copy link
Owner

Just waiting for CI, then I merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 81a825e into GuillaumeGomez:master Jun 24, 2020
@GuillaumeGomez
Copy link
Owner

Published the new version.

@arctic-alpaca arctic-alpaca deleted the temperature-fix branch June 24, 2020 12:06
@arctic-alpaca arctic-alpaca restored the temperature-fix branch June 24, 2020 12:07
@darnuria darnuria mentioned this pull request Sep 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No temperature output with the example code on Raspberry Pi 3B+
2 participants
@arctic-alpaca @GuillaumeGomez