Read more temperature data from hwmon on linux #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnuria
force-pushed
the
exploration/moar-hwmon-linux
branch
from
6208a51
to
79f2e16
Compare
|
small forcepush to rebase onto |
|
Thanks for early review, sorry for the hwmon thing noise, learned a lot while toying around, i did a big comment but can split if it's worth it, had a big design hesitation while doing it. |
darnuria
commented
Aug 31, 2022
darnuria
commented
Aug 31, 2022
darnuria
commented
Aug 31, 2022
darnuria
commented
Aug 31, 2022
darnuria
commented
Aug 31, 2022
|
Made some change to fix CI. Had issue with |
darnuria
force-pushed
the
exploration/moar-hwmon-linux
branch
from
ffc687d
to
c2ca79d
Compare
darnuria
force-pushed
the
exploration/moar-hwmon-linux
branch
from
c2ca79d
to
b48f05b
Compare
src/traits.rs
Outdated
Comment on lines
1507
to
1510
| /// ## Linux hwmon | ||
| /// | ||
| /// Read current Maximum value encountered may be computed by sysinfo | ||
| /// or from kernel in case of an errors, returns `f32::NAN`. |
There was a problem hiding this comment.
Suggested change
| /// ## Linux hwmon | |
| /// | |
| /// Read current Maximum value encountered may be computed by sysinfo | |
| /// or from kernel in case of an errors, returns `f32::NAN`. | |
| /// ## Linux | |
| /// | |
| /// Returns `f32::NAN` if an error occurred. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Tried to found a common ground on about to explain the behaviour without being too verbose.
darnuria
commented
Sep 2, 2022
src/traits.rs
Outdated
Comment on lines
1507
to
1510
| /// ## Linux hwmon | ||
| /// | ||
| /// Read current Maximum value encountered may be computed by sysinfo | ||
| /// or from kernel in case of an errors, returns `f32::NAN`. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Fix clippy lint error
Not needed since raspbian 10.
What it does? Expose new things: (Read only) - Expose a label that mimic `sensors` own (breaking change) - Sensor type - Allow reading of everything with a temp sensor. - Highest form kernel/chip maximum historical read value, is read from hardware OR from computation. - Thresolds max, critical, low Also fully remove raspberry-pi special code. Not everything is used, maybe a HwmonLinux specific trait can be done and use a degraded view to comply with existing cross-os `Component`. Future work? Read Fan, Voltage, Intrusion alert?
darnuria
force-pushed
the
exploration/moar-hwmon-linux
branch
from
40f9ea3
to
8e95cf8
Compare
GuillaumeGomez
approved these changes
Sep 3, 2022
|
Thanks a lot for all these improvements! |
|
No problem that was fun! Don't hesitate to @-me in case of regression, bugs or any issue about it. Also opened #826 for discussing reading more data from hwmon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May supplant #823, may help in #826.
Component/ComponentExttraits (labelsandmax)Read things that are not used now, maybe doing a Linux specific Hwmon richer trait?
Not exhaustive checklist of what is done:
tempN_highestvalue or computed max (may need testing?)Backport some doc?