Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose font fallback #260

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Conversation

GulajavaMinistudio
Copy link
Owner

Summary

Fixes yarnpkg#6439

The chocolately install has always been full of log spam due to an incorrectly written /l*v flag, but those logs are also unneeded since the output has no useful info so I just removed them (this can be reversed to just fix the flag if y'all really want it back).

This also removes the bad nodejs-lts nuget dependency added in yarnpkg#5925. It now has no dependency, and instead logs out to inform the user to install node if it's missing.

Test plan

  • choco uninstall yarn
  • Replace the {VERSION} and {CHECKSUM} placeholders manually or do a full build (I manually replaced)
  • .\chocolateyinstall.ps1

Summary

Test plan

**Summary**

Fixes #6439 

The chocolately install has always been full of log spam due to an incorrectly written `/l*v` flag, but those logs are also unneeded since the output has no useful info so I just removed them (this can be reversed to just fix the flag if y'all really want it back).

This also removes the bad `nodejs-lts` nuget dependency added in #5925. It now has no dependency, and instead logs out to inform the user to install node if it's missing.

**Test plan**

* `choco uninstall yarn`
* Replace the `{VERSION}` and `{CHECKSUM}` placeholders manually or do a full build (I manually replaced)
* `.\chocolateyinstall.ps1`
@GulajavaMinistudio GulajavaMinistudio merged commit 8bb40ff into GulajavaMinistudio:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad chocolatey package dependency
2 participants