Replace Chocolatey nodejs dependency with nodejs-lts. #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LTS releases of nodejs are less likely to break other parts of a project.
|
The test failures on test-linux-node6 don't seem related to my changes: |
BYK
reviewed
Jun 12, 2018
| @@ -36,7 +36,7 @@ utilization. | |||
| <bugTrackerUrl>https://github.com/yarnpkg/yarn/issues</bugTrackerUrl> | |||
| <releaseNotes>https://github.com/yarnpkg/yarn/releases/tag/v$version$</releaseNotes> | |||
| <dependencies> | |||
| <dependency id="nodejs.install" version="6.0" /> | |||
| <dependency id="nodejs-lts" version="6.0" /> | |||
There was a problem hiding this comment.
We should also bump this to 8, right?
|
Sorry I missed this. Seems fine to me. I wish we could specify that either nodejs.install or nodejs-lts is fine. |
Daniel15
pushed a commit
that referenced
this pull request
Dec 21, 2018
**Summary** Fixes #6439 The chocolately install has always been full of log spam due to an incorrectly written `/l*v` flag, but those logs are also unneeded since the output has no useful info so I just removed them (this can be reversed to just fix the flag if y'all really want it back). This also removes the bad `nodejs-lts` nuget dependency added in #5925. It now has no dependency, and instead logs out to inform the user to install node if it's missing. **Test plan** * `choco uninstall yarn` * Replace the `{VERSION}` and `{CHECKSUM}` placeholders manually or do a full build (I manually replaced) * `.\chocolateyinstall.ps1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the Chocolatey package's nodejs.install dependency with nodejs-lts. Since Yarn doesn't require the latest version of NodeJS depending on the LTS release should cause less situations where a user's other tools are not compatible with the NodeJS version installed via Chocolatey.
The nodejs.install package's documentation recommends depending on nodejs-lts, and some people have requested this change on the Chocolatey discussion page.
Test plan
I verified that the Chocolatey package is buildable and installs, I don't expect this to cause issues since the change is quite trivial.