-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto: move rules context into a structured object #491
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 70.19% 70.47% +0.27%
==========================================
Files 48 48
Lines 3013 3028 +15
Branches 648 653 +5
==========================================
+ Hits 2115 2134 +19
+ Misses 710 704 -6
- Partials 188 190 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
This PR is a following up of #481.
It's mainly a code structure improvement which aims to improve readability, testing and maintainability:
Next (spoiler alert): a CLI command to generate the rules context to make the rules writing more handy