Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cli): add command to export rules context in current environment #492

Merged
merged 9 commits into from
Apr 23, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Apr 23, 2024

Following up #491.

This PR adds a new CLI command to allow export rules context in the current environment. It aims to make rules writing easier:

> qdt export-rules-context -o qdt_rules_context.json
Rules context exported in qdt_rules_context.json

@Guts Guts requested a review from jmkerloch April 23, 2024 10:40
@Guts Guts self-assigned this Apr 23, 2024
@Guts Guts force-pushed the feature/cli-rules-context-export branch from 2dda5f0 to 5aff9ed Compare April 23, 2024 10:40
@github-actions github-actions bot added enhancement New feature or request quality Tests, project resiliency, etc. labels Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.79%. Comparing base (c7f7608) to head (2399230).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   70.47%   70.79%   +0.31%     
==========================================
  Files          48       48              
  Lines        3028     3054      +26     
  Branches      653      654       +1     
==========================================
+ Hits         2134     2162      +28     
+ Misses        704      702       -2     
  Partials      190      190              
Flag Coverage Δ
unittests 70.17% <96.66%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/cli.py 80.70% <100.00%> (+1.85%) ⬆️
qgis_deployment_toolbelt/profiles/rules_context.py 100.00% <ø> (ø)
..._deployment_toolbelt/commands/cmd_rules_context.py 95.83% <95.83%> (ø)

... and 1 file with indirect coverage changes

@Guts Guts linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 23, 2024
docs/usage/download_section.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts requested a review from jmkerloch April 23, 2024 12:22
Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Guts Guts merged commit 8fbd297 into main Apr 23, 2024
26 checks passed
@Guts Guts deleted the feature/cli-rules-context-export branch April 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add conditions on profile deployment
3 participants