Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUIDialog Python Proc fixes #416

Merged
merged 2 commits into from
Jul 8, 2024
Merged

GUIDialog Python Proc fixes #416

merged 2 commits into from
Jul 8, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jul 8, 2024

  • Fixes an error when a PythonFileMod tries to set itself as the proc for a GUIDialog (which happens when a dialog is passed in as a Python attribute)
  • Fixes a case where GUIDialogs would get added as pool objects to the scene node, but also (incorrectly) get attached as modifiers to a SceneObject. This can cause Uru to crash because things load in the wrong order (which is its own problem that I'm not spending more time debugging tonight)
  • Allow creating node trees in GUI pages. Sometimes you want a PythonFileMod in a GUI page, or sometimes you want a ResponderModifier in a GUI page.
  • Fix a case where all ATC anims were being listed as pool objects which is not necessary except in the case of avatar animations (and those should in future probably be special cased like GUI pages are)

korman/nodes/node_python.py Outdated Show resolved Hide resolved
korman/nodes/node_python.py Outdated Show resolved Hide resolved
korman/nodes/node_python.py Outdated Show resolved Hide resolved
korman/nodes/node_python.py Outdated Show resolved Hide resolved
dpogue and others added 2 commits July 8, 2024 14:42
@Hoikas Hoikas merged commit 5fcbb99 into H-uru:master Jul 8, 2024
3 checks passed
@dpogue dpogue deleted the gui-fixes branch July 8, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants