Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI Page type to pl_page_types for Modifiers #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DoobesURU
Copy link
Contributor

I noticed this while working on getting face/swivel mods working for Empty objects (another issue). The modifier properties use room and gui in pl_page_types to determine which modifier can work in which type of page. I found this wasn't working completely due to a missing reference in the base.py script. This fix adds the reference and gets the missing modifiers working for GUIs, such as the Advanced mod for Python scripts.

* Adds the gui page reference to pl_page_types for modifier properties (this fix excludes external for obvious reasons)
@DoobesURU
Copy link
Contributor Author

Note that I purposely excluded "external" for obvious reasons. 😉

@dpogue
Copy link
Member

dpogue commented Aug 28, 2024

I'm not sure that swivel mods make sense on objects that are part of a GUI? What was your use case here?

@DoobesURU
Copy link
Contributor Author

I'm not sure that swivel mods make sense on objects that are part of a GUI? What was your use case here?

No, sorry. As I said, that's a separate issue. I just happened to notice it while digging in the scripts for it. This is just a fix to use the existing modifier definitions in the associated scripts in properties/modifiers/.

@Hoikas
Copy link
Member

Hoikas commented Aug 28, 2024

This doesn't look quite right to me... My thinking was that only a very narrow set of modifiers would be useful in a GUI page, so, by default, we would only make a modifier available to room pages. Modifiers need to opt-into being available for gui pages. If there's any modifier that should be available in a GUI page but isn't, we'll want to add pl_page_types = {"room", "gui"} to that modifier specifically.

@DoobesURU
Copy link
Contributor Author

This doesn't look quite right to me... My thinking was that only a very narrow set of modifiers would be useful in a GUI page, so, by default, we would only make a modifier available to room pages. Modifiers need to opt-into being available for gui pages. If there's any modifier that should be available in a GUI page but isn't, we'll want to add pl_page_types = {"room", "gui"} to that modifier specifically.

That seems to be already implemented into each script in properties/modifier already. This, as far as I can tell, is telling the base.py script to use those existing definitions in the other scripts. /shrug

@dpogue
Copy link
Member

dpogue commented Aug 28, 2024

Adding the "gui" option to a specific modifier worked for me in #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants