Fix External Page Export #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small fix to stop pages set to External from triggering the "invalid page" error.
Hoikas
reviewed
Sep 1, 2024
| @@ -213,7 +213,7 @@ def _collect_objects(self): | |||
|
|
|||
| if (default_enabled and not page) or (page in pages_enabled): | |||
| self._objects.append(obj) | |||
| elif page not in all_pages or page in external_pages: | |||
| elif page not in all_pages or page not in external_pages: | |||
There was a problem hiding this comment.
I think this is correct as-is. What this is supposed to be doing is checking that all of the Plasma Objects are in pages that exists in the Plasma Age panel. If not, it reports that object as being in an invalid page. Further, we check if the object is in an external page. If it is, that's also an error because external pages are, by definition, not supposed to be created or touched by Korman, so no object in the blend file should be in an external page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to stop pages set to External from triggering the "invalid page" error.