Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix External Page Export #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix External Page Export #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion korman/exporter/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def _collect_objects(self):

if (default_enabled and not page) or (page in pages_enabled):
self._objects.append(obj)
elif page not in all_pages or page in external_pages:
elif page not in all_pages or page not in external_pages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct as-is. What this is supposed to be doing is checking that all of the Plasma Objects are in pages that exists in the Plasma Age panel. If not, it reports that object as being in an invalid page. Further, we check if the object is in an external page. If it is, that's also an error because external pages are, by definition, not supposed to be created or touched by Korman, so no object in the blend file should be in an external page.

error.add(page, obj.name)
inc_progress()
error.raise_if_error()
Expand Down